Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(remix-dev): when using jsconfig, include js in jsconfig files instead of ts #3012

Merged
merged 6 commits into from
Sep 15, 2022
Merged

chore(remix-dev): when using jsconfig, include js in jsconfig files instead of ts #3012

merged 6 commits into from
Sep 15, 2022

Conversation

mcansh
Copy link
Collaborator

@mcansh mcansh commented Apr 28, 2022 •
edited by MichaelDeBoey
Loading

Depends on #2961

@39digits 39digits mentioned this pull request Apr 29, 2022
Closed
@MichaelDeBoey MichaelDeBoey linked an issue Apr 29, 2022 that may be closed by this pull request
Create Remix jsconfig.json still contains references to include remix.env.d.ts, ts, and tsx #2967
Closed
@MichaelDeBoey MichaelDeBoey mentioned this pull request May 10, 2022
Merged
@mcansh
Copy link
Collaborator Author

mcansh commented Aug 10, 2022

handled by #3150

@mcansh mcansh closed this Aug 10, 2022
@mcansh mcansh deleted the logan/jsconfig branch August 10, 2022 19:13
@MichaelDeBoey
Copy link
Member

@mcansh Only the changes to convert-to-javascript are included in #3150.

The other changes you made could still be valuable I think 🤔

@mcansh mcansh restored the logan/jsconfig branch August 11, 2022 23:47
@mcansh mcansh reopened this Aug 11, 2022
@changeset-bot
Copy link

changeset-bot bot commented Aug 11, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 259fc1b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mcansh mcansh force-pushed the logan/jsconfig branch 2 times, most recently from 07d1f6f to a0dfc84 Compare August 25, 2022 16:48
mcansh and others added 6 commits September 8, 2022 22:04
@mcansh @MichaelDeBoey
chore(remix-dev): when using jsconfig, include js files instead of ts
7cae2f5 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
(cherry picked from commit 203ee0c)
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh @MichaelDeBoey
Update packages/remix-dev/compiler/utils/tsconfig/write-config-defaul…
aed652e 
…ts.ts

Co-authored-by: Michaël De Boey <info@michaeldeboey.be>
@mcansh @MichaelDeBoey
test if writing a jsconfig, delete the tsconfig at location
d9b1483 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
(cherry picked from commit 23ea431)
@mcansh @MichaelDeBoey
chore: move tsconfig defaults check to readConfig
4b150d8 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh @MichaelDeBoey
chore: update log
e616455 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh @MichaelDeBoey
test: update fixtures
259fc1b 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@chaance chaance merged commit ce604e9 into dev Sep 15, 2022
@chaance chaance deleted the logan/jsconfig branch September 15, 2022 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelDeBoey MichaelDeBoey MichaelDeBoey approved these changes

Assignees
No one assigned
Labels
CLA Signed package:dev
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Remix jsconfig.json still contains references to include remix.env.d.ts, ts, and tsx
3 participants
@mcansh @MichaelDeBoey @chaance